linux-kernel - Re: [PATCH v3 2/2] nvmem: Add RAVE SP EEPROM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 May 2018 11:35:43 -0700
From:   Andrey Smirnov <andrew.smirnov@...il.com>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Chris Healy <cphealy@...il.com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Aleksander Morgado <aleksander@...ksander.es>
Subject: Re: [PATCH v3 2/2] nvmem: Add RAVE SP EEPROM driver

On Tue, May 1, 2018 at 8:33 AM, Srinivas Kandagatla
<srinivas.kandagatla@...aro.org> wrote:
>
>
> On 01/05/18 06:29, Andrey Smirnov wrote:
>>
>> +// SPDX-License-Identifier: GPL-2.0+
>
> ...
>>
>> +MODULE_LICENSE("GPL");
>
> I think this should be
> MODULE_LICENSE("GPL v2");

With that change the two statements would contradict each other. "GPL"
means "GNU Public License v2 or later", whereas "GPL v2" means "GNU
Public License v2" as per
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/module.h#n175

Thanks,
Andrey Smirnov