linux-kernel - Re: [PATCH] 1wire: family module autoload fails because of upper/lower case mismatch.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 01 May 2018 21:54:37 +0300
From:   Evgeniy Polyakov <zbr@...emap.net>
To:     Ingo Flaschberger <ingo.flaschberger@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] 1wire: family module autoload fails because of upper/lower case mismatch.

Hi Ingo

Sorry for late reply and because of forcing you to resend the patch, your changes are correct

01.05.2018, 17:10, "Ingo Flaschberger" <ingo.flaschberger@...il.com>:
> 1wire family module autoload fails because of upper/lower
>   case mismatch.
>
> Signed-off-by: Ingo Flaschberger <ingo.flaschberger@...il.com>

Greg, please pull this patch into your tree.
Should it be stable material?

Acked-by: Evgeniy Polyakov <zbr@...emap.net>

> ---
>   drivers/w1/w1.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
> index ab0931e..aa458f2 100644
> --- a/drivers/w1/w1.c
> +++ b/drivers/w1/w1.c
> @@ -741,7 +741,7 @@ int w1_attach_slave_device(struct w1_master *dev,
> struct w1_reg_num *rn)
>
>          /* slave modules need to be loaded in a context with unlocked
> mutex */
>          mutex_unlock(&dev->mutex);
> -       request_module("w1-family-0x%02x", rn->family);
> +       request_module("w1-family-0x%02X", rn->family);
>          mutex_lock(&dev->mutex);
>
>          spin_lock(&w1_flock);
> --
> 2.7.4