[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAL_JsqKs7Jb0yCM+mUHwqRfrhzCPar1rHq4J+cCyxne=rVoV3g@mail.gmail.com>
Date: Tue, 1 May 2018 16:33:07 -0500
From: Rob Herring <robh+dt@...nel.org>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: Javier Martinez Canillas <javierm@...hat.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
devicetree@...r.kernel.org,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
linux-input@...r.kernel.org,
Nicolas Ferre <nicolas.ferre@...rochip.com>,
Nick Dyer <nick@...anahar.org>,
Mark Rutland <mark.rutland@....com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2] Input: atmel_mxt_ts - add missing compatible strings
to OF device table
On Tue, May 1, 2018 at 3:57 PM, Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:
> From: Javier Martinez Canillas <javierm@...hat.com>
>
> Commit af503716ac14 ("i2c: core: report OF style module alias for devices
> registered via OF") fixed how the I2C core reports the module alias when
> devices are registered via OF.
>
> But the atmel_mxt_ts driver only has an "atmel,maxtouch" compatible in its
> OF device ID table, so if a Device Tree is using a different one, autoload
> won't be working for the module (the matching works because the I2C device
> ID table is used as a fallback).
>
> So add compatible strings for each of the entries in the I2C device table.
>
> Fixes: af503716ac14 ("i2c: core: report OF style module alias for devices registered via OF")
> Reported-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>
> Tested-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> [dtor: document which compatibles are deprecated and should not be used]
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> ---
> .../devicetree/bindings/input/atmel,maxtouch.txt | 7 +++++++
> drivers/input/touchscreen/atmel_mxt_ts.c | 5 +++++
> 2 files changed, 12 insertions(+)
Reviewed-by: Rob Herring <robh@...nel.org>
Someone is going to make the dts updates, right?
Powered by blists - more mailing lists