linux-kernel - Re: [PATCH 2/2] clk: qcom: Add video clock controller driver for SDM845

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d311e4d7-7ba8-0b26-93c7-5ee06db466ef@codeaurora.org>
Date:   Wed, 2 May 2018 13:26:35 +0530
From:   "Nischal, Amit" <anischal@...eaurora.org>
To:     Stephen Boyd <sboyd@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...eaurora.org>
Cc:     Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        Odelu Kukatla <okukatla@...eaurora.org>,
        Taniya Das <tdas@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH 2/2] clk: qcom: Add video clock controller driver for
 SDM845



On 5/2/2018 3:11 AM, Stephen Boyd wrote:
> Quoting Amit Nischal (2018-04-24 06:32:51)
>> Add support for the video clock controller found on SDM845
>> based devices. This would allow video drivers to probe and
>> control their clocks.
>>
>> Signed-off-by: Amit Nischal <anischal@...eaurora.org>
> Driver looks small and good. Only concern is that there aren't resets
> defined, but the binding says there are resets. Will you add them?
Thanks for the review.
As of now, there are no resets defined for VIDEOCC. So I will move
the #reset-cells tooptional property in the dt-binding.
Same will be updated in the next patch series.
>
> I'm going to wait for the respin on the dts binding anyway.
Yes, I will send the next patch series soon.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-clk" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html