linux-kernel - Re: [PATCH] Enable clock before calling clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180502083420.GA8549@er01809n.ebgroup.elektrobit.com>
Date:   Wed, 2 May 2018 10:34:26 +0200
From:   Stefan Potyra <Stefan.Potyra@...ktrobit.com>
To:     Evgeniy Polyakov <zbr@...emap.net>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "ldv-project@...uxtesting.org" <ldv-project@...uxtesting.org>,
        "sil2review@...ts.osadl.org" <sil2review@...ts.osadl.org>
Subject: Re: [PATCH] Enable clock before calling clk_get_rate() on it.

Hi Evgeniy,

On Mon, Apr 30, 2018 at 06:02:57PM +0300, Evgeniy Polyakov wrote:
> Hi Stefan
> 
> Nice catch, thank you!
> 
> 19.04.2018, 16:02, "Stefan Potyra" <stefan.potyra@...ktrobit.com>:
> > According to the API, you may only call clk_get_rate() after actually
> > enabling it.
> >
> > Found by Linux Driver Verification project (linuxtesting.org).
> >
> > Fixes: a5fd9139f74c w1: add 1-wire master driver for i.MX27 / i.MX31
> > Signed-off-by: Stefan Potyra <Stefan.Potyra@...ktrobit.com>
> 
> Acked-by: Evgeniy Polyakov <zbr@...emap.net>

Oops, just saw that now the clock is leaked in the error case of mdev->regs.
I'll respin the patch and fix that.

Cheers,
  Stefan.

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)