linux-kernel - Re: [PATCH 1/2] dt-bindings: clock: Introduce QCOM RPMh clock bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <152527385298.138124.8046800128520264876@swboyd.mtv.corp.google.com>
Date:   Wed, 02 May 2018 08:10:52 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Taniya Das <tdas@...eaurora.org>
Cc:     Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        Odelu Kukatla <okukatla@...eaurora.org>,
        Amit Nischal <anischal@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, Taniya Das <tdas@...eaurora.org>
Subject: Re: [PATCH 1/2] dt-bindings: clock: Introduce QCOM RPMh clock bindings

Quoting Taniya Das (2018-05-02 03:51:16)
> Add RPMh clock device bindings for Qualcomm Technology Inc's SoCs. These
> devices would be used for communicating resource state requests to control
> the clocks managed by RPMh.
> 
> Signed-off-by: Taniya Das <tdas@...eaurora.org>
> Reviewed-by: Rob Herring <robh@...nel.org>

When you change things you shouldn't keep around reviewed-by tags if it
significantly changes..

> +Example :
> +
> +#include <dt-bindings/clock/qcom,rpmh.h>
> +
> +       &apps_rsc {
> +               rpmhcc: clock-controller {
> +                       compatible = "qcom,sdm845-rpmh-clk";
> +                       #clock-cells = <1>;
> +                       assigned-clocks = <&clock_rpmh RPMH_CXO_CLK>,
> +                                       <&clock_rpmh RPMH_CXO_CLK_A>,
> +                                       <&clock_rpmh RPMH_LN_BB_CLK2>,
> +                                       <&clock_rpmh RPMH_LN_BB_CLK2_A>,
> +                                       <&clock_rpmh RPMH_LN_BB_CLK3>,
> +                                       <&clock_rpmh RPMH_LN_BB_CLK3_A>;
> +                       assigned-clock-parents = <&xo_board_div>,
> +                                               <&xo_board_div>,
> +                                               <&xo_board_div>,
> +                                               <&xo_board_div>,
> +                                               <&xo_board_div>,
> +                                               <&xo_board_div>,

There's only one parent, so assigned-clock-parents doesn't really make
sense. If anything, we would have 'clocks = ' here and specify the xo
board clk and the div 2 clk that live in DT. But I already merged this
binding, two patchsets ago. Please look in clk-next.

> +               };
> +#define RPMH_RF_CLK2                           8
> +#define RPMH_RF_CLK2_A                         9
> +#define RPMH_RF_CLK3                           10
> +#define RPMH_RF_CLK3_A                         11
> +

Ok. I dropped CLK4* from the previous patch you sent and dropped Amit's
signed-off-by.