linux-kernel - Re: [PATCH v3] drm/i915: Disable some extra clang warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <152527554986.28472.11238909533010607091@mail.alporthouse.com>
Date:   Wed, 02 May 2018 16:39:09 +0100
From:   Chris Wilson <chris@...is-wilson.co.uk>
To:     Matthias Kaehlcke <mka@...omium.org>,
        "Jani Nikula" <jani.nikula@...ux.intel.com>,
        "Rodrigo Vivi" <rodrigo.vivi@...el.com>,
        "David Airlie" <airlied@...ux.ie>
Cc:     intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org,
        "Guenter Roeck" <groeck@...omium.org>,
        "Matthias Kaehlcke" <mka@...omium.org>
Subject: Re: [PATCH v3] drm/i915: Disable some extra clang warnings

Quoting Chris Wilson (2018-05-02 10:46:07)
> Quoting Matthias Kaehlcke (2018-05-01 19:24:40)
> > Commit 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set
> > warnings to full") enabled extra warnings for i915 to spot possible
> > bugs in new code, and then disabled a subset of these warnings to keep
> > the current code building without warnings (with gcc). Enabling the
> > extra warnings also enabled some additional clang-only warnings, as a
> > result building i915 with clang currently is extremely noisy. For now
> > also disable the clang warnings sign-compare, sometimes-uninitialized,
> > unneeded-internal-declaration and initializer-overrides. If desired
> > they can be re-enabled after the code has been fixed.
> > 
> > Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> Reviewed-by: Chris Wilson <chris@...is-wilson.co.uk>

I've picked this for inclusion and will push shortly.
Thanks for the patch,
-Chris