linux-kernel - Re: [RFC resend 1/2] modpost: delete stale comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNATDS3rqMRNa7GkzmeKYa-k=tTthSLMHG3ZBgKo1CgLUOw@mail.gmail.com>
Date:   Thu, 3 May 2018 00:51:20 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:     Michal Marek <michal.lkml@...kovi.net>,
        Rusty Russell <rusty@...tcorp.com.au>,
        Sam Ravnborg <sam@...nborg.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RFC resend 1/2] modpost: delete stale comment

2018-03-23 6:05 GMT+09:00 Rasmus Villemoes <linux@...musvillemoes.dk>:
> Commit (7840fea200cd "kbuild: Fix computing srcversion for modules")
> fixed the comment above parse_source_files to refer to the new source_
> line, but left this one behind that could still give the impression that
> drivers/net/dummy.c appears in the deps_ variable.
>
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> ---
> Resending because I didn't reach any current kbuild maintainers nor
> the kbuild mailing list.
>
>  scripts/mod/sumversion.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/scripts/mod/sumversion.c b/scripts/mod/sumversion.c
> index 944418da9fe3..0f6dcb4011a8 100644
> --- a/scripts/mod/sumversion.c
> +++ b/scripts/mod/sumversion.c
> @@ -330,14 +330,7 @@ static int parse_source_files(const char *objfile, struct md4_ctx *md)
>                 goto out;
>         }
>
> -       /* There will be a line like so:
> -               deps_drivers/net/dummy.o := \
> -                 drivers/net/dummy.c \
> -                   $(wildcard include/config/net/fastroute.h) \
> -                 include/linux/module.h \
> -
> -          Sum all files in the same dir or subdirs.
> -       */
> +       /* Sum all files in the same dir or subdirs. */
>         while ((line = get_next_line(&pos, file, flen)) != NULL) {
>                 char* p = line;
>
> --
> 2.15.1
>


Applied to linux-kbuild/fixes.  Thanks!



-- 
Best Regards
Masahiro Yamada