linux-kernel - Re: [PATCH v2 4/5] dt-bindings: devfreq: rk3399_dmc: remove interrupts as is not required.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <66622ef7-6b8a-c524-1f6e-e71ccbc72011@collabora.com>
Date:   Wed, 2 May 2018 18:11:16 +0200
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Rob Herring <robh@...nel.org>
Cc:     myungjoo.ham@...sung.com, kyungmin.park@...sung.com,
        devicetree@...r.kernel.org, ulf.hansson@...aro.org,
        heiko@...ech.de, linux-pm@...r.kernel.org, dbasehore@...omium.org,
        linux-kernel@...r.kernel.org, dianders@...gle.com,
        groeck@...omium.org, kernel@...labora.com, hl@...k-chips.com,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH v2 4/5] dt-bindings: devfreq: rk3399_dmc: remove
 interrupts as is not required.

Hi Rob,

Thanks for the review.

On 27/04/18 22:00, Rob Herring wrote:
> On Tue, Apr 24, 2018 at 10:37:41AM +0200, Enric Balletbo i Serra wrote:
>> In ATF we already wait for DDR dvfs finish, so don't need to do this in
>> kernel, so remove the interrupts properties as is not longer required.
> 
> If the hardware has an interrupt, then the DT should have one. The 
> partitioning with ATF shouldn't matter.
> 
> Now, if you want to make ATF remove the interrupt, then maybe that is 
> okay. But it's not clear to me why you'd expose some of the h/w and not 
> all.
> 

Ok, sounds good if I move interrupts to be optional then?

Best regards,
 Enric

>>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
>> Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com>
>> ---
>>
>> Changes in v2:
>> - [4/6] Add Reviewed-by Chanwoo Choi.
>>
>>  Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt | 5 -----
>>  1 file changed, 5 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt b/Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt
>> index 834637c7bae7..e7f0ef9548b7 100644
>> --- a/Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt
>> +++ b/Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt
>> @@ -5,10 +5,6 @@ Required properties:
>>  - devfreq-events:	 Node to get DDR loading, Refer to
>>  			 Documentation/devicetree/bindings/devfreq/event/
>>  			 rockchip-dfi.txt
>> -- interrupts:		 The CPU interrupt number. The interrupt specifier
>> -			 format depends on the interrupt controller.
>> -			 It should be a DCF interrupt. When DDR DVFS finishes
>> -			 a DCF interrupt is triggered.
>>  - clocks:		 Phandles for clock specified in "clock-names" property
>>  - clock-names :		 The name of clock used by the DFI, must be
>>  			 "pclk_ddr_mon";
>> @@ -172,7 +168,6 @@ Example:
>>  	dmc: dmc {
>>  		compatible = "rockchip,rk3399-dmc";
>>  		devfreq-events = <&dfi>;
>> -		interrupts = <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
>>  		clocks = <&cru SCLK_DDRCLK>;
>>  		clock-names = "dmc_clk";
>>  		operating-points-v2 = <&dmc_opp_table>;
>> -- 
>> 2.17.0
>>