linux-kernel - Re: [tip:x86/urgent] x86/cpu: Restore CPUID_8000_0008

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <868ee0c5-d10a-157a-18cb-ef9ea0f6b220@linux.intel.com>
Date:   Wed, 2 May 2018 11:08:02 -0700
From:   Tim Chen <tim.c.chen@...ux.intel.com>
To:     mingo@...nel.org, jrg.otte@...il.com, tglx@...utronix.de,
        linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        hpa@...or.com, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/urgent] x86/cpu: Restore CPUID_8000_0008_EBX reload

On 05/02/2018 07:48 AM, tip-bot for Thomas Gleixner wrote:
> Commit-ID:  c65732e4f72124ca5a3a0dd3bee0d3cee39c7170
> Gitweb:     https://git.kernel.org/tip/c65732e4f72124ca5a3a0dd3bee0d3cee39c7170
> Author:     Thomas Gleixner <tglx@...utronix.de>
> AuthorDate: Mon, 30 Apr 2018 21:47:46 +0200
> Committer:  Thomas Gleixner <tglx@...utronix.de>
> CommitDate: Wed, 2 May 2018 16:44:38 +0200
> 

snip

> 
> In hindsight this should have used completely synthetic bits for IBRB,

s/IBRB/IBPB

> IBRS, STIBP instead of reusing the AMD bits, but that's for 4.18.
> 
> /me needs to find time to cleanup that steaming pile of ...
> 
> Fixes: d94a155c59c9 ("x86/cpu: Prevent cpuinfo_x86::x86_phys_bits adjustment corruption")
> Reported-by: Jörg Otte <jrg.otte@...il.com>
> Reported-by: Tim Chen <tim.c.chen@...ux.intel.com>

Fix works for me too.  You can also add 
Tested-by: Tim Chen <tim.c.chen@...ux.intel.com>

Thanks.

Tim

> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Tested-by: Jörg Otte <jrg.otte@...il.com>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: kirill.shutemov@...ux.intel.com
> Cc: Borislav Petkov <bp@...en8.de
> Link: https://lkml.kernel.org/r/alpine.DEB.2.21.1805021043510.1668@nanos.tec.linutronix.de
> ---