linux-kernel - Re: [PATCH v2 06/10] PCI: Introduce devm_of_pci_get_host_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38bb255b-925a-e373-1107-259734a15b9b@mentor.com>
Date:   Thu, 3 May 2018 10:15:20 +0300
From:   Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>
To:     Jan Kiszka <jan.kiszka@...mens.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        <linux-pci@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 06/10] PCI: Introduce
 devm_of_pci_get_host_bridge_resources()

On 04/30/2018 08:48 AM, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@...mens.com>
> 
> of_pci_get_host_bridge_resources() allocates the resource structures it
> fills dynamically, but none of its callers care to release them so far.
> Rather than requiring everyone to do this explicitly, introduce a
> managed version of that service. This differs API-wise only in taking a
> reference to the associated device, rather than to the device tree node.
> 
> As of_pci_get_host_bridge_resources() is an exported interface, we
> cannot simply drop it at this point. After converting all in-tree users
> to the new API, we will phase out the unmanaged one.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>

Reviewed-by: Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>
Tested-by: Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>

--
With best wishes,
Vladimir