linux-kernel - Re: [PATCH] mm/page_alloc: Remove useless parameter of finalise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20180503075111.GB4535@dhcp22.suse.cz>
Date:   Thu, 3 May 2018 09:51:11 +0200
From:   Michal Hocko <mhocko@...nel.org>
To:     Huaisheng Ye <yehs1@...ovo.com>
Cc:     akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, vbabka@...e.cz,
        mgorman@...hsingularity.net, pasha.tatashin@...cle.com,
        hannes@...xchg.org, penguin-kernel@...ove.SAKURA.ne.jp,
        colyli@...e.de, chengnt@...ovo.com
Subject: Re: [PATCH] mm/page_alloc: Remove useless parameter of finalise_ac

On Thu 03-05-18 11:42:09, Huaisheng Ye wrote:
> finalise_ac has parameter order which is not used at all.
> Remove it.
> 
> Signed-off-by: Huaisheng Ye <yehs1@...ovo.com>

Acked-by: Michal Hocko <mhocko@...e.com>

> ---
>  mm/page_alloc.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 905db9d..291e194 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -4326,8 +4326,7 @@ static inline bool prepare_alloc_pages(gfp_t gfp_mask, unsigned int order,
>  }
>  
>  /* Determine whether to spread dirty pages and what the first usable zone */
> -static inline void finalise_ac(gfp_t gfp_mask,
> -		unsigned int order, struct alloc_context *ac)
> +static inline void finalise_ac(gfp_t gfp_mask, struct alloc_context *ac)
>  {
>  	/* Dirty zone balancing only done in the fast path */
>  	ac->spread_dirty_pages = (gfp_mask & __GFP_WRITE);
> @@ -4358,7 +4357,7 @@ struct page *
>  	if (!prepare_alloc_pages(gfp_mask, order, preferred_nid, nodemask, &ac, &alloc_mask, &alloc_flags))
>  		return NULL;
>  
> -	finalise_ac(gfp_mask, order, &ac);
> +	finalise_ac(gfp_mask, &ac);
>  
>  	/* First allocation attempt */
>  	page = get_page_from_freelist(alloc_mask, order, alloc_flags, &ac);
> -- 
> 1.8.3.1
> 

-- 
Michal Hocko
SUSE Labs