linux-kernel - Re: [PATCH] mtd: nand: do not initialise statics to 0 or NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180503115527.35b2b2ae@bbrezillon>
Date:   Thu, 3 May 2018 11:55:27 +0200
From:   Boris Brezillon <boris.brezillon@...tlin.com>
To:     Arushi Singhal <arushisinghal19971997@...il.com>
Cc:     boris.brezillon@...e-electrons.com,
        Richard Weinberger <richard@....at>,
        linux-kernel@...r.kernel.org, Marek Vasut <marek.vasut@...il.com>,
        linux-mtd@...ts.infradead.org,
        Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        Brian Norris <computersforpeace@...il.com>,
        David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH] mtd: nand: do not initialise statics to 0 or NULL

Hi Arushi,

On Sat, 24 Mar 2018 15:47:27 +0530
Arushi Singhal <arushisinghal19971997@...il.com> wrote:

> This patch fixes the checkpatch.pl error to ams-delta.c.
> ERROR: do not initialise statics to 0 or NULL

Can you rebase on top of nand/next [1] and use
"mtd: rawnand: ams-delta: " for the subject prefix?

Thanks,

Boris

[1]http://git.infradead.org/linux-mtd.git/shortlog/refs/heads/nand/next

> 
> Signed-off-by: Arushi Singhal <arushisinghal19971997@...il.com>
> ---
>  drivers/mtd/nand/ams-delta.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/ams-delta.c b/drivers/mtd/nand/ams-delta.c
> index 6e7f6e0..8e89452 100644
> --- a/drivers/mtd/nand/ams-delta.c
> +++ b/drivers/mtd/nand/ams-delta.c
> @@ -35,7 +35,7 @@
>  /*
>   * MTD structure for E3 (Delta)
>   */
> -static struct mtd_info *ams_delta_mtd = NULL;
> +static struct mtd_info *ams_delta_mtd;
>  
>  /*
>   * Define partitions for flash devices