linux-kernel - Re: [PATCH v2] mtd: chips: Replace printk() with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180503120241.4b2d5010@bbrezillon>
Date:   Thu, 3 May 2018 12:02:41 +0200
From:   Boris Brezillon <boris.brezillon@...tlin.com>
To:     Arushi Singhal <arushisinghal19971997@...il.com>
Cc:     dwmw2@...radead.org,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Richard Weinberger <richard@....at>,
        linux-kernel@...r.kernel.org, Marek Vasut <marek.vasut@...il.com>,
        Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>
Subject: Re: [PATCH v2] mtd: chips: Replace printk() with pr_*()

On Sat, 24 Mar 2018 22:01:45 +0530
Arushi Singhal <arushisinghal19971997@...il.com> wrote:

> Using pr_<loglevel>() is more concise than printk(KERN_<LOGLEVEL>).
> This patch:
> * Replace printks having a log level with the appropriate
> pr_*() macros.
> * Indent the code where possible.
> * Remove periods from messages.
> 
> Signed-off-by: Arushi Singhal <arushisinghal19971997@...il.com>
> ---
> changes:
> Before printk() is changes to dev_*macro(), but it was not good idea
> because mtd->dev is only initialized after mtd_device_register() is called.
> 
>  drivers/mtd/chips/cfi_cmdset_0001.c | 130 +++++++++++++++++++-----------------

I see printk(KERN_ ...) in other files inside this directory. This
should be fixed too.