linux-kernel - Re: [PATCH v1 2/3] ARM: dts: stm32: add cec pins to stm32mp157c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 May 2018 14:16:26 +0200
From:   Alexandre Torgue <alexandre.torgue@...com>
To:     yannick fertre <yannick.fertre@...com>,
        Philippe Cornu <philippe.cornu@...com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Loic Pallardy <loic.pallardy@...com>,
        Gerald Baeza <gerald.baeza@...com>,
        Patrice Chotard <patrice.chotard@...com>,
        Kamel Kholti <kamel.kholti@...com>
CC:     Benjamin Gaignard <benjamin.gaignard@...com>
Subject: Re: [PATCH v1 2/3] ARM: dts: stm32: add cec pins to stm32mp157c

Hi Yannick

On 04/24/2018 09:54 AM, yannick fertre wrote:
> This patch adds cec support on stm32mp157c eval board.
> 
> Signed-off-by: Yannick Fertre <yannick.fertre@...com>
> ---
>   arch/arm/boot/dts/stm32mp157-pinctrl.dtsi | 9 +++++++++
>   1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/stm32mp157-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp157-pinctrl.dtsi
> index 6f044100..67b0349 100644
> --- a/arch/arm/boot/dts/stm32mp157-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/stm32mp157-pinctrl.dtsi
> @@ -14,6 +14,15 @@
>   			ranges = <0 0x50002000 0xa400>;
>   			pins-are-numbered;
>   
> +			cec_pins_a: cec@0 {
> +				pins {
> +					pinmux = <STM32_PINMUX('A', 15, AF4)>;
> +					bias-disable;
> +					drive-open-drain;
> +					slew-rate = <0>;
> +				};
> +			};
> +
>   			gpioa: gpio@...02000 {
>   				gpio-controller;
>   				#gpio-cells = <2>;
> 
Next time, please put pins group after gpio controller and don't use 
cec@0 but cec-0 to declare pins group. I'll change it this time during 
merge.

Thanks
Alex