linux-kernel - Re: [PATCH v7 05/13] perf/x86/intel/pt: Introduce a new function to get capability of Intel PT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <349c6c61-6b6a-31b8-c8c5-24aed5716929@redhat.com>
Date:   Thu, 3 May 2018 14:32:53 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     "Kang, Luwei" <luwei.kang@...el.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Cc:     "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
        "rkrcmar@...hat.com" <rkrcmar@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "joro@...tes.org" <joro@...tes.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "chao.p.peng@...ux.intel.com" <chao.p.peng@...ux.intel.com>
Subject: Re: [PATCH v7 05/13] perf/x86/intel/pt: Introduce a new function to
 get capability of Intel PT

On 03/05/2018 14:30, Kang, Luwei wrote:
>> Can you elaborate on this, what information do we need besides
>> MSR_IA32_VMX_MISC[14]?
>
> Enable Intel PT in guest depend on SECONDARY_EXEC_PT_USE_GPA, EPT,
> MSR_IA32_VMX_MISC[14] and the capability of " PT_CAP_topa_output" on
> hardware. PT driver will return " -ENODEV" if hardware not support
> "PT_CAP_topa_output".

I actually don't understand why PT_CAP_topa_output matters for the
purpose of enabling PT in the guest.  However you still need
__pt_cap_get() in the CPUID checks.

Paolo