linux-kernel - Re: [PATCH v2 2/3] intel-iommu: generalize __mapping_notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180503131424.jsn4qvfuwur7adcb@8bytes.org>
Date:   Thu, 3 May 2018 15:14:24 +0200
From:   Joerg Roedel <joro@...tes.org>
To:     Peter Xu <peterx@...hat.com>
Cc:     Linux IOMMU Mailing List <iommu@...ts.linux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        David Woodhouse <dwmw2@...radead.org>,
        Alex Williamson <alex.williamson@...hat.com>,
        Jintack Lim <jintack@...columbia.edu>,
        Alexander Witte <alexander.witte@...canada.com>
Subject: Re: [PATCH v2 2/3] intel-iommu: generalize __mapping_notify_one()

On Wed, Apr 18, 2018 at 04:39:52PM +0800, Peter Xu wrote:
> Generalize this new helper to notify one newly created mapping on one
> single IOMMU.  We can further leverage this helper in the next patch.

You introduce the function, you do not generalize it. Please fix that in
the subject and description.

Also, please drop patch 1, I don't like this pr_debug stuff in the
code. And please also fix the subject line in general to match the form:

	iommu/vt-d: _I_ntroduce __mapping_notify_one()

When that is done, please re-send.

Thanks,

	Joerg