linux-kernel - Re: [PATCH] backlight: remove obsolete comment for ->state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180503143238.lfxacqos7t6xuays@holly.lan>
Date:   Thu, 3 May 2018 15:32:38 +0100
From:   Daniel Thompson <daniel.thompson@...aro.org>
To:     Daniel Vetter <daniel.vetter@...ll.ch>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        DRI Development <dri-devel@...ts.freedesktop.org>,
        Jani Nikula <jani.nikula@...el.com>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Lee Jones <lee.jones@...aro.org>,
        Jingoo Han <jingoohan1@...il.com>
Subject: Re: [PATCH] backlight: remove obsolete comment for ->state

On Thu, May 03, 2018 at 04:15:17PM +0200, Daniel Vetter wrote:
> Jani spotted this when reviewing my earlier patch to remove the driver
> internal usage of this field in
> 
> commit 3cf91adaa594e8933af1727942ac560e5c7bc70e
> Author: Daniel Vetter <daniel.vetter@...ll.ch>
> Date:   Wed Apr 25 19:42:52 2018 +0200
> 
>     backlight: Nuke BL_CORE_DRIVER1
> 
> Cc: Jani Nikula <jani.nikula@...el.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@...el.com>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Daniel Thompson <daniel.thompson@...aro.org>
> Cc: Jingoo Han <jingoohan1@...il.com>

Acked-by: Daniel Thompson <daniel.thompson@...aro.org>

> ---
>  include/linux/backlight.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/backlight.h b/include/linux/backlight.h
> index 7fbf0539e14a..0b5897446dca 100644
> --- a/include/linux/backlight.h
> +++ b/include/linux/backlight.h
> @@ -79,7 +79,6 @@ struct backlight_properties {
>  	/* Backlight type */
>  	enum backlight_type type;
>  	/* Flags used to signal drivers of state changes */
> -	/* Upper 4 bits are reserved for driver internal use */
>  	unsigned int state;
>  
>  #define BL_CORE_SUSPENDED	(1 << 0)	/* backlight is suspended */
> -- 
> 2.17.0
>