linux-kernel - Re: [PATCH 1/1] watchdog: hpwdt: Claim NMIs generated by iLO5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180503212033.GA32321@roeck-us.net>
Date:   Thu, 3 May 2018 14:20:33 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Jerry Hoemann <jerry.hoemann@....com>
Cc:     wim@...ux-watchdog.org, linux-watchdog@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] watchdog: hpwdt: Claim NMIs generated by iLO5

On Thu, May 03, 2018 at 03:00:55PM -0600, Jerry Hoemann wrote:
> On iLO5 going forward we want to return and not claim the NMI, if
> the NMI was NOT gnerated by the iLO as a result of the watchdog
> timing out or an explicit generate NMI.
> 
> The sense of the test in is inverted and prevents hpwdt_pretimeout
> from claiming NMIs when it should.
> 
> Signed-off-by: Jerry Hoemann <jerry.hoemann@....com>

Fixes: a042229a18ac ("watchdog: hpwdt: Update nmi_panic message.")
Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/hpwdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
> index a43ab2cecca2..9dc62a461451 100644
> --- a/drivers/watchdog/hpwdt.c
> +++ b/drivers/watchdog/hpwdt.c
> @@ -159,7 +159,7 @@ static int hpwdt_pretimeout(unsigned int ulReason, struct pt_regs *regs)
>  		"3. OA Forward Progress Log\n"
>  		"4. iLO Event Log";
>  
> -	if (ilo5 && ulReason == NMI_UNKNOWN && mynmi)
> +	if (ilo5 && ulReason == NMI_UNKNOWN && !mynmi)
>  		return NMI_DONE;
>  
>  	if (ilo5 && !pretimeout)
> -- 
> 2.13.6
>