linux-kernel - [PATCH] swiotlb: Silent unwanted warning "buffer is full"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180503235446.6a3d3118@endymion>
Date:   Thu, 3 May 2018 23:54:46 +0200
From:   Jean Delvare <jdelvare@...e.de>
To:     iommu@...ts.linux-foundation.org
Cc:     linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>,
        Christian König <christian.koenig@....com>,
        Michel Dänzer 
        <michel@...nzer.net>, Takashi Iwai <tiwai@...e.de>
Subject: [PATCH] swiotlb: Silent unwanted warning "buffer is full"

If DMA_ATTR_NO_WARN is passed to swiotlb_alloc_buffer(), it should be
passed further down to swiotlb_tbl_map_single(). Otherwise we escape
half of the warnings but still log the other half.

This is one of the multiple causes of spurious warnings reported at:
https://bugs.freedesktop.org/show_bug.cgi?id=104082

Signed-off-by: Jean Delvare <jdelvare@...e.de>
Fixes: 0176adb00406 ("swiotlb: refactor coherent buffer allocation")
Cc: Christoph Hellwig <hch@....de>
Cc: Christian König <christian.koenig@....com>
Cc: Michel Dänzer <michel@...nzer.net>
Cc: Takashi Iwai <tiwai@...e.de>
Cc: stable@...r.kernel.org # v4.16
---
 lib/swiotlb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-4.16.orig/lib/swiotlb.c	2018-05-02 15:06:49.677769532 +0200
+++ linux-4.16/lib/swiotlb.c	2018-05-03 15:04:27.136921225 +0200
@@ -727,7 +727,7 @@ swiotlb_alloc_buffer(struct device *dev,
 
 	phys_addr = swiotlb_tbl_map_single(dev,
 			swiotlb_phys_to_dma(dev, io_tlb_start),
-			0, size, DMA_FROM_DEVICE, 0);
+			0, size, DMA_FROM_DEVICE, attrs);
 	if (phys_addr == SWIOTLB_MAP_ERROR)
 		goto out_warn;
 


-- 
Jean Delvare
SUSE L3 Support