linux-kernel - Re: [PATCH v2] clk: x86: Add ST oscout platform clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201805040610.d3xMxCsO%fengguang.wu@intel.com>
Date:   Fri, 4 May 2018 06:09:45 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Akshu Agrawal <akshu.agrawal@....com>
Cc:     kbuild-all@...org, djkurtz@...omium.org, akshu.agrawal@....com,
        Alexander.Deucher@....com,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Christian König <christian.koenig@....com>,
        Shaoyun Liu <Shaoyun.Liu@....com>,
        Dave Airlie <airlied@...hat.com>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:COMMON CLK FRAMEWORK" <linux-clk@...r.kernel.org>
Subject: Re: [PATCH v2] clk: x86: Add ST oscout platform clock

Hi Akshu,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on clk/clk-next]
[also build test WARNING on v4.17-rc3 next-20180503]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Akshu-Agrawal/clk-x86-Add-ST-oscout-platform-clock/20180503-214044
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next

smatch warnings:
drivers/clk/x86/clk-st.c:60 st_clk_probe() error: potential null dereference 'hws'.  (kzalloc returns null)

vim +/hws +60 drivers/clk/x86/clk-st.c

    48	
    49	static int st_clk_probe(struct platform_device *pdev)
    50	{
    51		struct st_clk_data *st_data;
    52		struct clk_hw **hws;
    53	
    54		st_data = dev_get_platdata(&pdev->dev);
    55		if (!st_data || !st_data->base)
    56			return -EINVAL;
    57	
    58		hws = kzalloc(sizeof(*hws) * ST_MAX_CLKS, GFP_KERNEL);
    59	
  > 60		hws[ST_CLK_48M] = clk_hw_register_fixed_rate(NULL, "clk48MHz", NULL, 0,
    61							     48000000);
    62		hws[ST_CLK_25M] = clk_hw_register_fixed_rate(NULL, "clk25MHz", NULL, 0,
    63							     25000000);
    64	
    65		hws[ST_CLK_MUX] = clk_hw_register_mux(NULL, "oscout1_mux",
    66			clk_oscout1_parents, ARRAY_SIZE(clk_oscout1_parents),
    67			0, st_data->base + CLKDRVSTR2, OSCOUT1CLK25MHZ, 3, 0, NULL);
    68	
    69		clk_set_parent(hws[ST_CLK_MUX]->clk, hws[ST_CLK_25M]->clk);
    70	
    71		hws[ST_CLK_GATE] = clk_hw_register_gate(NULL, "oscout1", "oscout1_mux",
    72			0, st_data->base + MISCCLKCNTL1, OSCCLKENB,
    73			CLK_GATE_SET_TO_DISABLE, NULL);
    74	
    75		clk_hw_register_clkdev(hws[ST_CLK_GATE], "oscout1", NULL);
    76	
    77		return 0;
    78	}
    79	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation