linux-kernel - Re: [PATCH 1/9] R3Di and SBZ quirk entires + alt firmware loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d719f92-805a-77bb-dd3e-34c3e1e26940@sakamocchi.jp>
Date:   Fri, 4 May 2018 17:25:58 +0900
From:   Takashi Sakamoto <o-takashi@...amocchi.jp>
To:     Connor McAdams <conmanx360@...il.com>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Jérémy Lefaure <jeremy.lefaure@....epita.fr>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/9] R3Di and SBZ quirk entires + alt firmware loading

Hi,

On May 04 2018 13:30, Connor McAdams wrote:
> Sorry for sending these twice, I made a formatting mistake in the
> first series, and they would not apply properly. Hopefully these do
> not show up as spam because of this.
> 
> I went through and fixed them all individually and re-committed them,
> but kept the same commit messages. I still have a lot to learn.

For this case, please use '--subject-prefix' option for 
git-format-patch. Like:

$ git format-patch --subject-prefix='PATCH v2'

Additionally, it's preferable to add 'ALSA: hda/ca0132: ' prefix for 
each patch. Like:

'ALSA: hda/ca0132: R3Di and SBZ quirk entires + alt firmware loading'

Furthermore, when posting several patches as a one series, it's 
preferable to post cover letter as well. Like:

$ git format-patch --cover-letter
0000-cover-letter.patch
...

Of course, it's better to write enough information in the cover letter. 
For its content, please refer to cover letters by the other developers 
in alsa-devel archive.
http://mailman.alsa-project.org/pipermail/alsa-devel/

Thanks

Takashi Sakamoto