linux-kernel - Re: [PATCH v1] drm/kms/mode: added a new helper for calculating videomode from crtc's display mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180504093854.GJ1027@e110455-lin.cambridge.arm.com>
Date:   Fri, 4 May 2018 10:38:54 +0100
From:   Liviu Dudau <liviu.dudau@....com>
To:     Satendra Singh Thakur <satendra.t@...sung.com>
Cc:     dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] drm/kms/mode: added a new helper for calculating
 videomode from crtc's display mode

On Fri, May 04, 2018 at 02:32:03PM +0530, Satendra Singh Thakur wrote:
> On Thu, May 03, 2018 at 11:36:39 +0100, Liviu Dudau wrote:
> > On Thu, May 03, 2018 at 11:28:37AM +0530, Satendra Singh Thakur wrote:
> > > 1.
> > > -Added a new helper drm_display_mode_crtc_to_videomode
> > > -This helper calculates mode parameters like
> > >   horizontal front_porch, back_porch, sync length
> > >   vertical front_porch, back_porch, sync length
> > >   using crtc_* fields of struct drm_display_mode
> > > -It uses following fields of crtc mode
> > >  horizontal sync start/end, active and total length
> > >  vertical sync start/end, active and total length
> > > 2.
> > > -Most of the driver use user-supplied mode for calculating videomode
> > > -However, few drivers use HW (crtc) mode for calculating videomode
> > > -This helper will be useful for such drivers
> > > 3.
> > > -Currently following drivers will be using this new helper
> > > -arm hdlcd
> > > -atmel hlcdc
> > > -exynos 5433 decon
> > > -exynos7 decon
> > > -exynos fimd
> > > 4.
> > > -This patch removes related duplicate code from above mentioned drivers
> > > 
> > > Signed-off-by: Satendra Singh Thakur <satendra.t@...sung.com>
> > > Cc: Madhur Verma <madhur.verma@...sung.com>
> > > Cc: Hemanshu Srivastava <hemanshu.s@...sung.com>
> > > ---
> > >  drivers/gpu/drm/arm/hdlcd_crtc.c               |  8 +-------
> > >  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c |  7 +------
> > >  drivers/gpu/drm/drm_modes.c                    | 20 ++++++++++++++++++++
> > >  drivers/gpu/drm/exynos/exynos5433_drm_decon.c  | 22 ++++++++++------------
> > >  drivers/gpu/drm/exynos/exynos7_drm_decon.c     | 23 ++++++++++-------------
> > >  drivers/gpu/drm/exynos/exynos_drm_fimd.c       | 22 +++++++++-------------
> > >  include/drm/drm_modes.h                        |  2 ++
> > >  7 files changed, 53 insertions(+), 51 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/arm/hdlcd_crtc.c b/drivers/gpu/drm/arm/hdlcd_crtc.c
> > > index cf5cbd6..d20e471 100644
> > > --- a/drivers/gpu/drm/arm/hdlcd_crtc.c
> > > +++ b/drivers/gpu/drm/arm/hdlcd_crtc.c
> > > @@ -130,13 +130,7 @@ static void hdlcd_crtc_mode_set_nofb(struct drm_crtc *crtc)
> > >  	struct videomode vm;
> > >  	unsigned int polarities, err;
> > >  
> > > -	vm.vfront_porch = m->crtc_vsync_start - m->crtc_vdisplay;
> > > -	vm.vback_porch = m->crtc_vtotal - m->crtc_vsync_end;
> > > -	vm.vsync_len = m->crtc_vsync_end - m->crtc_vsync_start;
> > > -	vm.hfront_porch = m->crtc_hsync_start - m->crtc_hdisplay;
> > > -	vm.hback_porch = m->crtc_htotal - m->crtc_hsync_end;
> > > -	vm.hsync_len = m->crtc_hsync_end - m->crtc_hsync_start;
> > > -
> > > +	drm_display_mode_crtc_to_videomode(m, &vm);
> > >  	polarities = HDLCD_POLARITY_DATAEN | HDLCD_POLARITY_DATA;
> > >  
> > >  	if (m->flags & DRM_MODE_FLAG_PHSYNC)
> >
> > For the HDLCD part:
> > 
> > Acked-by: Liviu Dudau <liviu.dudau@....com>
> > 
> > If you're not sending the final version through drm-misc then let me
> > know and I can pick up the HDLCD part separately.
> >
> > Best regards,
> > Liviu
> >
> >
> 
> Hi Mr Liviu,
> Thanks for accepting the patch.
> I don't know how to send patch through drm-misc.
> You may please go ahead and pick HDLCD part separately.

Lets wait for the maintainers of other drivers to give their ACKs and
then we'll sort out the submission. Usually it is just a matter of
asking for the patch to be pulled from the relevant people. For drm-misc
there are quite a few people and with enough patches accepted others can
join too. I'll just put here some names, in no particular order, that
you can ask for the patch to be pulled.

Gustavo Padovan <gustavo@...ovan.org>
Daniel Stone <daniel@...ishbar.org>
Eric Anholt <eric@...olt.net>
Jani Nikula <jani.nikula@...el.com>
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>
Sean Paul <seanpaul@...omium.org>
Daniel Vetter <daniel.vetter@...el.com>

Best regards,
Liviu

> 
> Thanks
> -Satendra

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯