linux-kernel - Re: [PATCH] block: add verifier for cmdline partition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3267b3ec-0500-5772-949e-49570395085d@kernel.dk>
Date:   Fri, 4 May 2018 08:20:08 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Caizhiyong <caizhiyong@...ilicon.com>,
        Wang YanQing <udknight@...il.com>
Cc:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "pombredanne@...b.com" <pombredanne@...b.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jiangheng <jiangheng@...ilicon.com>
Subject: Re: [PATCH] block: add verifier for cmdline partition

On 5/4/18 1:07 AM, Caizhiyong wrote:
>> -----Original Message-----
>> From: Wang YanQing [mailto:udknight@...il.com]
>> Sent: Thursday, May 03, 2018 7:18 PM
>> To: axboe@...nel.dk
>> Cc: gregkh@...uxfoundation.org; pombredanne@...b.com;
>> tglx@...utronix.de; Caizhiyong <caizhiyong@...ilicon.com>; linux-
>> block@...r.kernel.org; linux-kernel@...r.kernel.org
>> Subject: [PATCH] block: add verifier for cmdline partition
>>
>> I meet strange filesystem corruption issue recently, the reason
>> is there are overlaps partitions in cmdline partition argument.
>>
>> This patch add verifier for cmdline partition, then if there are
>> overlaps partitions, cmdline_partition will return error and log
>> a error message.
>>
> 
> Partition overlap was intentionally designed in this cmdline partition.
> some time, the cmdline partition save raw data(not filesystem), the overlap makes data  access very convenient.
> 
> reference  http://lists.infradead.org/pipermail/linux-mtd/2013-August/048092.html

Might make sense to warn about it at least, it can be very surprising if
it happens inadvertently.

-- 
Jens Axboe