linux-kernel - Re: [PATCH] media: lgdt3306a: fix lgdt3306a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cfa44c99-3ff7-899e-ad54-af24b0ea5b04@nextdimension.cc>
Date:   Thu, 3 May 2018 20:41:07 -0500
From:   Brad Love <brad@...tdimension.cc>
To:     Luc Van Oostenryck <luc.vanoostenryck@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Brad Love <brad@...tdimension.cc>,
        Michael Ira Krufky <mkrufky@...uxtv.org>,
        Hans Verkuil <hansverk@...co.com>,
        Thomas Meyer <thomas@...3r.de>, linux-media@...r.kernel.org
Subject: Re: [PATCH] media: lgdt3306a: fix lgdt3306a_search()'s return type

Acked-by: Brad Love <brad@...tdimension.cc>



On 2018-04-24 08:19, Luc Van Oostenryck wrote:
> The method dvb_frontend_ops::search() is defined as
> returning an 'enum dvbfe_search', but the implementation in this
> driver returns an 'int'.
>
> Fix this by returning 'enum dvbfe_search' in this driver too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@...il.com>
> ---
>  drivers/media/dvb-frontends/lgdt3306a.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-frontends/lgdt3306a.c b/drivers/media/dvb-frontends/lgdt3306a.c
> index 7eb4e1469..32de82447 100644
> --- a/drivers/media/dvb-frontends/lgdt3306a.c
> +++ b/drivers/media/dvb-frontends/lgdt3306a.c
> @@ -1784,7 +1784,7 @@ static int lgdt3306a_get_tune_settings(struct dvb_frontend *fe,
>  	return 0;
>  }
>  
> -static int lgdt3306a_search(struct dvb_frontend *fe)
> +static enum dvbfe_search lgdt3306a_search(struct dvb_frontend *fe)
>  {
>  	enum fe_status status = 0;
>  	int ret;