linux-kernel - Re: [PATCH v2] driver-core: Return EBUSY error instead of BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180504173709.GC4649@kroah.com>
Date:   Fri, 4 May 2018 10:37:09 -0700
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Florian Schmaus <flo@...kplace.eu>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] driver-core: Return EBUSY error instead of BUG_ON()

On Fri, May 04, 2018 at 03:23:57PM +0200, Florian Schmaus wrote:
> I triggerd the BUG_ON() in driver_register(), which was added in
> f48f3febb2cbfd0f2ecee7690835ba745c1034a4, when booting a domU Xen
> domain. Since there was no contextual information logged, I needed to
> attach kgdb to determine the culprit (the wmi-bmof driver in my case).
> 
> Instead of running into a BUG_ON() we print an error message
> identifying the driver but continue booting.
> 
> Signed-off-by: Florian Schmaus <flo@...kplace.eu>
> ---
>  drivers/base/driver.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 

What changed from v1?  Always put that below the --- line.

Also, it's best to quote commits with the following format:
	f48f3febb2cb ("driver-core: do not register a driver with bus_type not registered")

v3?

thanks,

greg k-h