linux-kernel - Re: [PATCH v3][RESEND] media: i2c: tda1997: replace codec to component

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180504155827.3a192297@vento.lan>
Date:   Fri, 4 May 2018 15:58:27 -0300
From:   Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
To:     Tim Harvey <tharvey@...eworks.com>, Takashi Iwai <tiwai@...e.de>
Cc:     Mark Brown <broonie@...nel.org>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Linux-ALSA <alsa-devel@...a-project.org>,
        linux-kernel@...r.kernel.org,
        linux-media <linux-media@...r.kernel.org>
Subject: Re: [PATCH v3][RESEND] media: i2c: tda1997: replace codec to
 component

Em Mon, 23 Apr 2018 13:59:32 -0700
Tim Harvey <tharvey@...eworks.com> escreveu:

> On Mon, Apr 23, 2018 at 9:52 AM, Mark Brown <broonie@...nel.org> wrote:
> > On Mon, Apr 23, 2018 at 09:44:17AM -0700, Tim Harvey wrote:
> >  
> >> Could you add some detail to the commit explaining why we need to
> >> replace codec to component? I don't really know what that means.
> >> Please refer to a commit if the ASoC API is changing in some way we
> >> need to catch up with.  
> >
> > This is a big transition in the ASoC API which is nearing completion -
> > this driver is one of the last users of the CODEC struct, we've (well,
> > mainly Morimoto-san) been migrating things away from it to the more
> > general purpose component.  There's no one commit to point at really as
> > the two have coexisted for a while and we won't be able to finally
> > remove the CODEC struct until all the drivers have transitioned away.  
> 
> Mark,
> 
> Ok - thanks for the explanation!
> 
> Kuninori,
> 
> Sorry this took so long to get to. Tested on a GW5404
> 
> Tested-by: Tim Harvey <tharvey@...eworks.com>
> Acked-by: Tim Harvey <tharvey@...eworks.com>

In order to keep it together with the patches doing the removal of
the old API, it is probably better to apply this via ALSA tree:

Acked-by: Mauro Carvalho Chehab <mchehab+samsung@...nel.org>

> 
> Regards,
> 
> Tim



Thanks,
Mauro