[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAD=FV=Ux+Ei0HE5FWnUrMBjWqh4ZVfobfbZfJTfKn54o4fmq5g@mail.gmail.com>
Date: Fri, 4 May 2018 12:47:18 -0700
From: Doug Anderson <dianders@...omium.org>
To: Manu Gautam <mgautam@...eaurora.org>
Cc: Kishon Vijay Abraham I <kishon@...com>,
Rob Herring <robh@...nel.org>, Stephen Boyd <sboyd@...nel.org>,
devicetree@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
Evan Green <evgreen@...omium.org>,
Vivek Gautam <vivek.gautam@...eaurora.org>,
linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v5 6/7] dt-bindings: phy-qcom-usb2: Add support to
override tuning values
Hi,
On Wed, May 2, 2018 at 2:06 PM, Manu Gautam <mgautam@...eaurora.org> wrote:
> To improve eye diagram for PHYs on different boards of same SOC,
> some parameters may need to be changed. Provide device tree
> properties to override these from board specific device tree
> files. While at it, replace "qcom,qusb2-v2-phy" with compatible
> string for USB2 PHY on sdm845 which was earlier added for
> sdm845 only.
>
> Signed-off-by: Manu Gautam <mgautam@...eaurora.org>
> ---
> .../devicetree/bindings/phy/qcom-qusb2-phy.txt | 23 +++++++++++++-
> include/dt-bindings/phy/phy-qcom-qusb2.h | 37 ++++++++++++++++++++++
> 2 files changed, 59 insertions(+), 1 deletion(-)
> create mode 100644 include/dt-bindings/phy/phy-qcom-qusb2.h
Thanks for adding the #defines, describing the defaults, and including
which SoCs the new properties work on. This looks great to me now,
thanks!
Reviewed-by: Douglas Anderson <dianders@...omium.org>
Powered by blists - more mailing lists