linux-kernel - Re: [PATCH] cxgb4vf: fix t4vf_eth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BY2PR1201MB0983B5AE34A93565090F4BB8C8860@BY2PR1201MB0983.namprd12.prod.outlook.com>
Date:   Fri, 4 May 2018 21:41:56 +0000
From:   Casey Leedom <leedom@...lsio.com>
To:     Luc Van Oostenryck <luc.vanoostenryck@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] cxgb4vf: fix t4vf_eth_xmit()'s return type

| From: Luc Van Oostenryck <luc.vanoostenryck@...il.com>
| Sent: Tuesday, April 24, 2018 6:19:02 AM
| 
| The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
| which is a typedef for an enum type, but the implementation in this
| driver returns an 'int'.
| 
| Fix this by returning 'netdev_tx_t' in this driver too.

Looks good to me.

Casey