[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 5 May 2018 10:12:29 +0100
From: Mark Rutland <mark.rutland@....com>
To: Peter Zijlstra <peterz@...radead.org>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
aryabinin@...tuozzo.com, boqun.feng@...il.com,
catalin.marinas@....com, dvyukov@...gle.com, mingo@...nel.org,
will.deacon@....com
Subject: Re: [PATCH 1/6] locking/atomic, asm-generic: instrument ordering
variants
On Fri, May 04, 2018 at 08:24:22PM +0200, Peter Zijlstra wrote:
> On Fri, May 04, 2018 at 07:09:09PM +0100, Mark Rutland wrote:
> > On Fri, May 04, 2018 at 08:01:05PM +0200, Peter Zijlstra wrote:
> > > On Fri, May 04, 2018 at 06:39:32PM +0100, Mark Rutland wrote:
>
> > > > include/asm-generic/atomic-instrumented.h | 1195 ++++++++++++++++++++++++-----
> > > > 1 file changed, 1008 insertions(+), 187 deletions(-)
> > >
> > > Is there really no way to either generate or further macro compress this?
> >
> > I can definitely macro compress this somewhat, but the bulk of the
> > repetition will be the ifdeffery, which can't be macro'd away IIUC.
>
> Right, much like what we already have in linux/atomic.h I suspect,
> having to duplicating that isn't brilliant either.
>
> > Generating this with a script is possible -- do we do anything like that
> > elsewhere?
>
> There's include/generated/ in your build directory. But nothing on this
> scale I think.
Sure. I'm not familiar with how we generate those, so I'll go digging through
the build infrastructure.
Thanks,
Mark.
Powered by blists - more mailing lists