lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 5 May 2018 02:10:35 +0000 From: Huaisheng HS1 Ye <yehs1@...ovo.com> To: Michal Hocko <mhocko@...nel.org> CC: "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>, "linux-mm@...ck.org" <linux-mm@...ck.org>, "vbabka@...e.cz" <vbabka@...e.cz>, "mgorman@...hsingularity.net" <mgorman@...hsingularity.net>, "pasha.tatashin@...cle.com" <pasha.tatashin@...cle.com>, "alexander.levin@...izon.com" <alexander.levin@...izon.com>, "hannes@...xchg.org" <hannes@...xchg.org>, "penguin-kernel@...ove.SAKURA.ne.jp" <penguin-kernel@...ove.SAKURA.ne.jp>, "colyli@...e.de" <colyli@...e.de>, NingTing Cheng <chengnt@...ovo.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [External] Re: [PATCH 3/3] mm/page_alloc: Fix typo in debug info of calculate_node_totalpages > On Fri 04-05-18 14:52:09, Huaisheng Ye wrote: > > realtotalpages is calculated by taking off absent_pages from > > spanned_pages in every zone. > > Debug message of calculate_node_totalpages shall accurately > > indicate that it is real totalpages to avoid ambiguity. > > Is the printk actually useful? Why don't we simply remove it? You can > get the information from /proc/zoneinfo so why to litter the dmesg > output? Indeed, we can get the amount of pfns as spanned, present and managed from /proc/zoneinfo after memory initialization has been finished. But this printk is a relatively meaningful reference within dmesg log. Especially for people who doesn't have much experience, or someone has a plan to modify boundary of zones within free_area_init_*. Sincerely, Huaisheng Ye Linux kernel | Lenovo > > > Signed-off-by: Huaisheng Ye <yehs1@...ovo.com> > > --- > > mm/page_alloc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index 1b39db4..9d57db2 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -5967,7 +5967,7 @@ static void __meminit > calculate_node_totalpages(struct pglist_data *pgdat, > > > > pgdat->node_spanned_pages = totalpages; > > pgdat->node_present_pages = realtotalpages; > > - printk(KERN_DEBUG "On node %d totalpages: %lu\n", pgdat->node_id, > > + printk(KERN_DEBUG "On node %d realtotalpages: %lu\n", > pgdat->node_id, > > realtotalpages); > > } > > > > -- > > 1.8.3.1
Powered by blists - more mailing lists