[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 5 May 2018 09:31:50 +0900
From: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
To: adobriyan@...il.com, akpm@...ux-foundation.org
Cc: linux-kernel@...r.kernel.org, mhocko@...e.com
Subject: Re: [PATCH] elf: don't hash userspace addresses
Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
> ---
>
> fs/binfmt_elf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/fs/binfmt_elf.c
> +++ b/fs/binfmt_elf.c
> @@ -379,8 +379,8 @@ static unsigned long elf_map(struct file *filep, unsigned long addr,
>
> if ((type & MAP_FIXED_NOREPLACE) &&
> PTR_ERR((void *)map_addr) == -EEXIST)
> - pr_info("%d (%s): Uhuuh, elf segment at %px requested but the memory is mapped already\n",
> - task_pid_nr(current), current->comm, (void *)addr);
> + pr_info("%d (%s): Uhuuh, elf segment at %lx requested but the memory is mapped already\n",
> + task_pid_nr(current), current->comm, addr);
"%px" does not hash. For what reason you replace %px with %lx ?
>
> return(map_addr);
> }
>
Powered by blists - more mailing lists