linux-kernel - Re: [PATCH] thermal: tegra: soctherm: add const to struct thermal_cooling_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180506225044.GA25956@localhost.localdomain>
Date:   Sun, 6 May 2018 15:50:45 -0700
From:   Eduardo Valentin <edubezval@...il.com>
To:     srplinux2008 <srplinux2008@...il.com>
Cc:     thierry.reding@...il.com, jonathanh@...dia.com,
        linux-tegra@...r.kernel.org, rui.zhang@...el.com,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH] thermal: tegra: soctherm: add const to struct
 thermal_cooling_device_ops

On Sun, Apr 08, 2018 at 05:31:45PM +0530, srplinux2008 wrote:
> From: srp linux <srplinux2008@...il.com>
> 
> Correct the typecast with const to struct thermal_cooling_device_ops.
> It is the last argument to the function thermal_of_cooling_device_register
> and this argument is of type const. So, declare this structure
> thermal_cooling_device_ops as constant.
> 
> Signed-off-by: srp linux <srplinux2008@...il.com>

Please resend with your real name.

Thanks

> ---
>  drivers/thermal/tegra/soctherm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c
> index 455b58c..72da745 100644
> --- a/drivers/thermal/tegra/soctherm.c
> +++ b/drivers/thermal/tegra/soctherm.c
> @@ -926,7 +926,7 @@ static int throt_set_cdev_state(struct thermal_cooling_device *cdev,
>  	return 0;
>  }
>  
> -static struct thermal_cooling_device_ops throt_cooling_ops = {
> +static const struct thermal_cooling_device_ops throt_cooling_ops = {
>  	.get_max_state = throt_get_cdev_max_state,
>  	.get_cur_state = throt_get_cdev_cur_state,
>  	.set_cur_state = throt_set_cdev_state,
> -- 
> 2.7.4
>