| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 6 May 2018 14:30:14 +0800
From: Baoquan He <bhe@...hat.com>
To: kbuild test robot <lkp@...el.com>
Cc: kbuild-all@...org, linux-kernel@...r.kernel.org,
akpm@...ux-foundation.org, robh+dt@...nel.org,
dan.j.williams@...el.com, nicolas.pitre@...aro.org,
josh@...htriplett.org, Brijesh Singh <brijesh.singh@....com>,
devicetree@...r.kernel.org, David Airlie <airlied@...ux.ie>,
linux-pci@...r.kernel.org, Wei Yang <richard.weiyang@...il.com>,
Keith Busch <keith.busch@...el.com>,
Yaowei Bai <baiyaowei@...s.chinamobile.com>,
Frank Rowand <frowand.list@...il.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
Stephen Hemminger <sthemmin@...rosoft.com>,
linux-nvdimm@...ts.01.org,
Patrik Jakobsson <patrik.r.jakobsson@...il.com>,
linux-input@...r.kernel.org, Borislav Petkov <bp@...e.de>,
Tom Lendacky <thomas.lendacky@....com>,
Haiyang Zhang <haiyangz@...rosoft.com>,
Jérôme Glisse <jglisse@...hat.com>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Thomas Gleixner <tglx@...utronix.de>,
Jonathan Derrick <jonathan.derrick@...el.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
devel@...uxdriverproject.org
Subject: Re: [PATCH v3 1/3] resource: Use list_head to link sibling resource
On 04/26/18 at 11:23am, kbuild test robot wrote:
> Hi Baoquan,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on linus/master]
> [also build test ERROR on v4.17-rc2 next-20180424]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Baoquan-He/resource-Use-list_head-to-link-sibling-resource/20180419-223752
> config: xtensa-common_defconfig (attached as .config)
> compiler: xtensa-linux-gcc (GCC) 7.2.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> make.cross ARCH=xtensa
>
> All errors (new ones prefixed by >>):
>
> In file included from arch/xtensa/lib/pci-auto.c:22:0:
> arch/xtensa/include/asm/pci-bridge.h: In function 'pcibios_init_resource':
> >> arch/xtensa/include/asm/pci-bridge.h:74:15: error: incompatible types when assigning to type 'struct list_head' from type 'void *'
> res->sibling = NULL;
> ^
> arch/xtensa/include/asm/pci-bridge.h:75:13: error: incompatible types when assigning to type 'struct list_head' from type 'void *'
> res->child = NULL;
Thanks, below fix can fix it.
diff --git a/arch/xtensa/include/asm/pci-bridge.h b/arch/xtensa/include/asm/pci-bridge.h
index 0b68c76ec1e6..f487b06817df 100644
--- a/arch/xtensa/include/asm/pci-bridge.h
+++ b/arch/xtensa/include/asm/pci-bridge.h
@@ -71,8 +71,8 @@ static inline void pcibios_init_resource(struct resource *res,
res->flags = flags;
res->name = name;
res->parent = NULL;
- res->sibling = NULL;
- res->child = NULL;
+ INIT_LIST_HEAD(&res->child);
+ INIT_LIST_HEAD(&res->sibling);
}
> ^
>
> vim +74 arch/xtensa/include/asm/pci-bridge.h
>
> 9a8fd558 include/asm-xtensa/pci-bridge.h Chris Zankel 2005-06-23 65
> 9a8fd558 include/asm-xtensa/pci-bridge.h Chris Zankel 2005-06-23 66 static inline void pcibios_init_resource(struct resource *res,
> 9a8fd558 include/asm-xtensa/pci-bridge.h Chris Zankel 2005-06-23 67 unsigned long start, unsigned long end, int flags, char *name)
> 9a8fd558 include/asm-xtensa/pci-bridge.h Chris Zankel 2005-06-23 68 {
> 9a8fd558 include/asm-xtensa/pci-bridge.h Chris Zankel 2005-06-23 69 res->start = start;
> 9a8fd558 include/asm-xtensa/pci-bridge.h Chris Zankel 2005-06-23 70 res->end = end;
> 9a8fd558 include/asm-xtensa/pci-bridge.h Chris Zankel 2005-06-23 71 res->flags = flags;
> 9a8fd558 include/asm-xtensa/pci-bridge.h Chris Zankel 2005-06-23 72 res->name = name;
> 9a8fd558 include/asm-xtensa/pci-bridge.h Chris Zankel 2005-06-23 73 res->parent = NULL;
> 9a8fd558 include/asm-xtensa/pci-bridge.h Chris Zankel 2005-06-23 @74 res->sibling = NULL;
> 9a8fd558 include/asm-xtensa/pci-bridge.h Chris Zankel 2005-06-23 75 res->child = NULL;
> 9a8fd558 include/asm-xtensa/pci-bridge.h Chris Zankel 2005-06-23 76 }
> 9a8fd558 include/asm-xtensa/pci-bridge.h Chris Zankel 2005-06-23 77
>
> :::::: The code at line 74 was first introduced by commit
> :::::: 9a8fd5589902153a134111ed7a40f9cca1f83254 [PATCH] xtensa: Architecture support for Tensilica Xtensa Part 6
>
> :::::: TO: Chris Zankel <czankel@...silica.com>
> :::::: CC: Linus Torvalds <torvalds@...970.osdl.org>
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
Powered by blists - more mailing lists