linux-kernel - RE: [RFC net-next 4/5] net: phy: Add support for IEEE standard test modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9235D6609DB808459E95D78E17F2E43D40D62045@CHN-SV-EXMX02.mchp-main.com>
Date:   Mon, 7 May 2018 00:02:25 +0000
From:   <Woojung.Huh@...rochip.com>
To:     <f.fainelli@...il.com>, <netdev@...r.kernel.org>
CC:     <andrew@...n.ch>, <rmk@...linux.org.uk>,
        <linux-kernel@...r.kernel.org>, <davem@...emloft.net>,
        <cphealy@...il.com>, <nikita.yoush@...entembedded.com>,
        <vivien.didelot@...oirfairelinux.com>, <Nisar.Sayed@...rochip.com>,
        <UNGLinuxDriver@...rochip.com>
Subject: RE: [RFC net-next 4/5] net: phy: Add support for IEEE standard test
 modes

Hi Florian,

> Well, the way the code is structure is that if you call that function
> with a test mode value that is not part of the standard set, it returns
> -EOPNOTSUPP, so if your particular PHY driver wants to "overlay"
> standard and non-standard modes, it can by using that hint.
> 
> This should work even if we have more standard test modes in the future
> because the test modes are dynamically fetched by user-space using the
> ETH_GSTRINGS ioctl().
> 
> Does that cover what you had in mind?
Basically, agree on your explanation.

My idea was making genphy_set_test() more expandable for other test modes
because it would be a good place to add more standard test modes later.

No problem to keep current codes.

Thanks.
Woojung