linux-kernel - Re: [PATCH v3 5/9] ALSA: hda/ca0132: add/change helper functions for R3Di and SBZ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9918d3d1-d843-6142-ca95-91ee0bde3d6b@sakamocchi.jp>
Date:   Mon, 7 May 2018 11:29:38 +0900
From:   Takashi Sakamoto <o-takashi@...amocchi.jp>
To:     Connor McAdams <conmanx360@...il.com>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Jérémy Lefaure <jeremy.lefaure@....epita.fr>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 5/9] ALSA: hda/ca0132: add/change helper functions for
 R3Di and SBZ

Hi,

On May 6 2018 04:03, Connor McAdams wrote:
> Edit core functions to support the Sound Blaster Z and Recon3Di for
> startup and loading of the DSP, as well as setting effects.
> 
> Signed-off-by: Connor McAdams <conmanx360@...il.com>
> ---
>   sound/pci/hda/patch_ca0132.c | 1064 ++++++++++++++++++++++++++++++++++++++++--
>   1 file changed, 1018 insertions(+), 46 deletions(-)

In my opinion, this patch is too large. This patch can be split into
several parts:

  * Changes for signature of 'dspio_scp()' to get 'src_id'
   * dspio_scp()
   * dspio_set_param()
   * dspio_set_uint_param()
   * dspio_alloc_dma_chan()
   * dspio_free_dma_chan()
  * Changes for SBZ only
  * Changes for R3Di only

Could you please prepare for these three patches from this large patch 
in your next chance? Especially, you can describe enough information to 
the latter two patches as patch comment.


Thanks

Takashi Sakamoto