linux-kernel - Re: [PATCH 1/6] powerpc/syscalls: Switch trivial cases to SYSCALL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y3gw6v9x.fsf@concordia.ellerman.id.au>
Date:   Mon, 07 May 2018 12:42:50 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     "Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>,
        linuxppc-dev@...abs.org
Cc:     linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk
Subject: Re: [PATCH 1/6] powerpc/syscalls: Switch trivial cases to SYSCALL_DEFINE

"Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com> writes:

> Michael Ellerman wrote:
>> From: Al Viro <viro@...iv.linux.org.uk>
>> 
>> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
>> ---
>>  arch/powerpc/kernel/pci_32.c               | 6 +++---
>>  arch/powerpc/kernel/pci_64.c               | 4 ++--
>>  arch/powerpc/mm/subpage-prot.c             | 4 +++-
>>  arch/powerpc/platforms/cell/spu_syscalls.c | 3 ++-
>>  4 files changed, 10 insertions(+), 7 deletions(-)
>> 
>
> I suppose we can also do this for switch_endian?

Yeah. It'd nice to have an automated test that every syscall is
available via FTRACE_SYSCALLS, I just haven't got around to writing one.

cheers

> diff --git a/arch/powerpc/kernel/syscalls.c b/arch/powerpc/kernel/syscalls.c
> index 466216506eb2..290265f2700c 100644
> --- a/arch/powerpc/kernel/syscalls.c
> +++ b/arch/powerpc/kernel/syscalls.c
> @@ -123,7 +123,7 @@ long ppc_fadvise64_64(int fd, int advice, u32 offset_high, u32 offset_low,
>  				 (u64)len_high << 32 | len_low, advice);
>  }
>  
> -long sys_switch_endian(void)
> +SYSCALL_DEFINE0(switch_endian)
>  {
>  	struct thread_info *ti;
>
>
> - Naveen