linux-kernel - Re: [PATCH v2] dell-wmi: Set correct keycode for Fn + left arrow hotkey

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VdJ23PEY_7MBJ6o7DTj=Pk2no2KBkL_+sqWQry1q_pgYA@mail.gmail.com>
Date:   Mon, 7 May 2018 17:12:44 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Pali Rohár <pali.rohar@...il.com>
Cc:     Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Mario Limonciello <mario.limonciello@...l.com>,
        Henk <henk.vergonet@...il.com>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] dell-wmi: Set correct keycode for Fn + left arrow hotkey

On Tue, May 1, 2018 at 2:11 PM, Pali Rohár <pali.rohar@...il.com> wrote:
> From: Henk <henk.vergonet@...il.com>
>
> Fn + left arrow hotkey combination is used for enabling/disabling automatic
> display brigthness based on integrated ALS sensor. For this purpose there
> is standard linux key KEY_BRIGHTNESS_AUTO so use it instead of KEY_UNKNOWN.
>
> Tested on Dell Lattitude E6500.
>

Pushed to my review and testing queue, thanks!


> Signed-off-by: Henk Vergonet <henk.vergonet@...il.com>
> Reviewed-By: Pali Rohár <pali.rohar@...il.com>
> Reviewed-By: Mario Limonciello <mario.limonciello@...l.com>
> ---
> Changes since v1 by Pali
> * Update commit description
> ---
>  drivers/platform/x86/dell-wmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index 8d102195..7c918e37 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -233,7 +233,7 @@ static const u16 bios_to_linux_keycode[256] = {
>         [18]    = KEY_PROG1,
>         [19]    = KEY_BRIGHTNESSDOWN,
>         [20]    = KEY_BRIGHTNESSUP,
> -       [21]    = KEY_UNKNOWN,
> +       [21]    = KEY_BRIGHTNESS_AUTO,
>         [22]    = KEY_KBDILLUMTOGGLE,
>         [23]    = KEY_UNKNOWN,
>         [24]    = KEY_SWITCHVIDEOMODE,
> --
> 2.11.0
>



-- 
With Best Regards,
Andy Shevchenko