linux-kernel - Re: [systemd-devel] [PATCH bluez] hid2hci: Fix udev rules for linux-4.14+

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180507174459.GH8805@in.waw.pl>
Date:   Mon, 7 May 2018 17:44:59 +0000
From:   Zbigniew Jędrzejewski-Szmek <zbyszek@...waw.pl>
To:     Ville Syrjala <ville.syrjala@...ux.intel.com>
Cc:     linux-bluetooth@...r.kernel.org,
        Kay Sievers <kay.sievers@...y.org>,
        systemd-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [systemd-devel] [PATCH bluez] hid2hci: Fix udev rules for
 linux-4.14+

On Mon, May 07, 2018 at 04:06:38PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@...ux.intel.com>
> 
> Since commit 1455cf8dbfd0 ("driver core: emit uevents when
> device is bound to a driver") the kernel started emitting
> "bound" and "unbound" uevents which confuse the hid2hci
> udev rules.
> 
> The symptoms on an affected machine (Dell E5400 in my case)
> include bluetooth devices not appearing and udev hogging
> the cpu as it's busy processing a constant stream of these
> "bound"+"unbound" uevents.
> 
> Change the udev rules only kick in for an "add" event.
> This seems to cure my machine at least.
> 
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Marcel Holtmann <marcel@...tmann.org>
> Cc: Kay Sievers <kay.sievers@...y.org>
> Cc: systemd-devel@...ts.freedesktop.org
> Cc: linux-kernel@...r.kernel.org
> Cc: linux-bluetooth@...r.kernel.org
> Signed-off-by: Ville Syrjälä <ville.syrjala@...ux.intel.com>
> ---
>  tools/hid2hci.rules | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/hid2hci.rules b/tools/hid2hci.rules
> index db6bb03d2ef3..daa381d77387 100644
> --- a/tools/hid2hci.rules
> +++ b/tools/hid2hci.rules
> @@ -1,6 +1,6 @@
>  # do not edit this file, it will be overwritten on update
>  
> -ACTION=="remove", GOTO="hid2hci_end"
> +ACTION!="add", GOTO="hid2hci_end"
>  SUBSYSTEM!="usb*", GOTO="hid2hci_end"

This will skip over lines 22-23. Is the rule there supposed to
work for ACTION==add only (in which case your patch would be OK),
or also for ACTION==change? Maybe it'd be safer to just add the GOTO
for bind/unbind.

Zbyszek