linux-kernel - Re: [PATCH 14/24] selftests: kvm: return Kselftest Skip code for skipped tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 May 2018 14:19:17 -0600
From:   Shuah Khan <shuah@...nel.org>
To:     Paolo Bonzini <pbonzini@...hat.com>, hofsass@...gle.com
Cc:     linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH 14/24] selftests: kvm: return Kselftest Skip code for
 skipped tests

On 05/07/2018 01:41 PM, Shuah Khan wrote:
> On 05/07/2018 05:46 AM, Paolo Bonzini wrote:
>> On 05/05/2018 03:13, Shuah Khan (Samsung OSG) wrote:
>>> When kvm test is skipped because of unmet dependencies and/or unsupported
>>> configuration, it exits with error which is treated as a fail by the
>>> Kselftest framework. This leads to false negative result even when the test
>>> could not be run.
>>>
>>> Change it to return kselftest skip code when a test gets skipped to clearly
>>> report that the test could not be run.
>>>
>>> Change it to use ksft_exit_skip() when the test is skipped. In addition,
>>> refine test_assert() message to include strerror() string and add explicit
>>> check for root user to clearly identofy non-root user skip case.
>>
>> Root should not be needed.
> 
> Will remove the root check and send v2.

Hmm. I am seeing 

selftests: kvm: sync_regs_test
========================================
==== Test Assertion Failure ====
  lib/kvm_util.c:54: kvm_fd >= 0
  pid=2840 tid=2840 - Permission denied
     1	0x0000564cd5206163: ?? ??:0
     2	0x0000564cd520531b: ?? ??:0
     3	0x00007f7ec018f1c0: ?? ??:0
     4	0x0000564cd52058f9: ?? ??:0
  open /dev/kvm failed, rc: -1 errno: 13

There are a couple of other tests that fail with EACCES
It would make sense report these tests as Skipped perhaps.

thanks,
-- Shuah