linux-kernel - Re: [PATCH 3/3] staging: wilc1000: Remove unnecessary array index check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180507112527.0037a95e@ajaysk-VirtualBox>
Date:   Mon, 7 May 2018 11:25:27 +0530
From:   Ajay Singh <ajay.kathat@...rochip.com>
To:     Nathan Chancellor <natechancellor@...il.com>
CC:     <devel@...verdev.osuosl.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-wireless@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Ganesh Krishna <ganesh.krishna@...rochip.com>,
        Aditya Shankar <aditya.shankar@...rochip.com>
Subject: Re: [PATCH 3/3] staging: wilc1000: Remove unnecessary array index
 check

On Sun, 6 May 2018 00:33:33 -0700
Nathan Chancellor <natechancellor@...il.com> wrote:

> This statment triggers GCC's -Wtype-limit since key_index is an
> unsigned integer so it cannot be less than zero.
> 
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

Reviewed-by: Ajay Singh <ajay.kathat@...rochip.com>

> ---
>  drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c index
> b499fb987395..e0015ca6c21a 100644 ---
> a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +++
> b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c @@ -1054,7
> +1054,7 @@ static int del_key(struct wiphy *wiphy, struct net_device
> *netdev, } }
>  
> -	if (key_index >= 0 && key_index <= 3 &&
> priv->wep_key_len[key_index]) {
> +	if (key_index <= 3 && priv->wep_key_len[key_index]) {
>  		memset(priv->wep_key[key_index], 0,
>  		       priv->wep_key_len[key_index]);
>  		priv->wep_key_len[key_index] = 0;