linux-kernel - Re: [PATCH v4] PCI / PM: Always check PME wakeup capability for runtime wakeup support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <11148593.jpbL9ipGSX@aspire.rjw.lan>
Date:   Wed, 09 May 2018 00:14:22 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Kai-Heng Feng <kai.heng.feng@...onical.com>, bhelgaas@...gle.com,
        rafael.j.wysocki@...el.com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v4] PCI / PM: Always check PME wakeup capability for runtime wakeup support

On Monday, May 7, 2018 11:48:17 PM CEST Bjorn Helgaas wrote:
> On Mon, May 07, 2018 at 02:11:20PM +0800, Kai-Heng Feng wrote:
> > USB controller ASM1042 stops working after commit de3ef1eb1cd0 ("PM /
> > core: Drop run_wake flag from struct dev_pm_info").
> > 
> > The device in question is not power managed by platform firmware,
> > furthermore, it only supports PME# from D3cold:
> > Capabilities: [78] Power Management version 3
> >        Flags: PMEClk- DSI- D1- D2- AuxCurrent=55mA PME(D0-,D1-,D2-,D3hot-,D3cold+)
> >        Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
> > 
> > Before commit de3ef1eb1cd0, the device never gets runtime suspended.
> > After that commit, the device gets runtime suspended to D3hot, which can
> > not generate any PME#.
> > 
> > usb_hcd_pci_probe() unconditionally calls device_wakeup_enable(), hence
> > device_can_wakeup() in pci_dev_run_wake() always returns true.
> > 
> > So pci_dev_run_wake() needs to check PME wakeup capability as its first
> > condition.
> > 
> > In addition, change wakeup flag passed to pci_target_state() from false
> > to true, because we want to find the deepest state that the device can
> > still generate PME#. In this case, it's D0 for the device in question.
> > 
> > Fixes: de3ef1eb1cd0 ("PM / core: Drop run_wake flag from struct dev_pm_info")
> > Cc: stable@...r.kernel.org # 4.13+
> > Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
> 
> Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> Rafael, can you queue this up?  de3ef1eb1cd0 went through your tree,
> and I don't really understand the patch, so I'll rely on your review.

I will, thanks!