linux-kernel - RE: [PATCH] Drivers: hv: vmbus: enable VMBus protocol version 5.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <KL1P15301MB00064D52564FA764B6B00CE9BF9A0@KL1P15301MB0006.APCP153.PROD.OUTLOOK.COM>
Date:   Tue, 8 May 2018 23:06:02 +0000
From:   Dexuan Cui <decui@...rosoft.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
CC:     "'gregkh@...uxfoundation.org'" <gregkh@...uxfoundation.org>,
        "'driverdev-devel@...uxdriverproject.org'" 
        <driverdev-devel@...uxdriverproject.org>,
        KY Srinivasan <kys@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "Michael Kelley (EOSG)" <Michael.H.Kelley@...rosoft.com>,
        "'olaf@...fle.de'" <olaf@...fle.de>,
        Jork Loeser <Jork.Loeser@...rosoft.com>,
        "'jasowang@...hat.com'" <jasowang@...hat.com>,
        "'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
        "'marcelo.cerri@...onical.com'" <marcelo.cerri@...onical.com>,
        "'apw@...onical.com'" <apw@...onical.com>,
        "'vkuznets@...hat.com'" <vkuznets@...hat.com>
Subject: RE: [PATCH] Drivers: hv: vmbus: enable VMBus protocol version 5.0

> From: Stephen Hemminger <stephen@...workplumber.org>
> Sent: Tuesday, May 8, 2018 15:45
> On Tue, 8 May 2018 22:26:21 +0000
> Dexuan Cui <decui@...rosoft.com> wrote:
> 
> > @@ -63,6 +63,9 @@ static __u32 vmbus_get_next_version(__u32
> current_version)
> >  	case (VERSION_WIN10):
> >  		return VERSION_WIN8_1;
> >
> > +	case (VERSION_WIN10_V5):
> > +		return VERSION_WIN10;
> > +
> >  	case (VERSION_WS2008):
> 
> In a future patch, we should get rid of the use of parenthesis on this switch
> statement.  Lots of other cleanup of this code is possible as well.

I agree.
We can make another patch to clean up this function. Maybe we should
replace the function with an array of versions.

Thanks,
-- Dexuan