linux-kernel - Re: [PATCH] xen: xenbus: Fix a possible data race in xs_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <770bc26b-3819-2235-132f-55b0319955dd@gmail.com>
Date:   Tue, 8 May 2018 15:04:13 +0800
From:   Jia-Ju Bai <baijiaju1990@...il.com>
To:     Juergen Gross <jgross@...e.com>, boris.ostrovsky@...cle.com,
        simon@...isiblethingslab.com, joao.m.martins@...cle.com
Cc:     xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xen: xenbus: Fix a possible data race in xs_request_enter



On 2018/5/8 15:02, Juergen Gross wrote:
> On 08/05/18 05:34, Jia-Ju Bai wrote:
>> The read operation to "req->type" is protected by
>> the lock on line 128, but the write operation to
>> this data on line 118 is not protected by the lock.
>> Thus, there may exist a data race for "req->type".
>>
>> To fix this data race, the write operation to "req->type"
>> should be also protected by the lock.
> No, xs_request_enter() is never called for a request already visible to
> another thread or processor. So no race exists.

Okay, thanks for your reply.


Best wishes,
Jia-Ju Bai