linux-kernel - Re: [RFC PATCH 2/3] arcnet: com20020: Fixup missing SLOWARB bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f17492c1-8565-2a69-22a8-c3abde0c7283@gmail.com>
Date:   Tue, 8 May 2018 11:52:25 +0200
From:   Andrea Greco <andrea.greco.gapmilano@...il.com>
To:     "Tobin C. Harding" <tobin@...orbit.com>
Cc:     m.grzeschik@...gutronix.de, Andrea Greco <a.greco@...gma.it>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 2/3] arcnet: com20020: Fixup missing SLOWARB bit

On 05/07/2018 04:55 AM, Tobin C. Harding wrote:
> On Sat, May 05, 2018 at 11:37:54PM +0200, Andrea Greco wrote:
>> From: Andrea Greco <a.greco@...gma.it>
>>
>> If com20020 clock is major of 40Mhz SLOWARB bit is requested.
>>
>> Signed-off-by: Andrea Greco <a.greco@...gma.it>
>> ---
>>   drivers/net/arcnet/com20020.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/net/arcnet/com20020.c b/drivers/net/arcnet/com20020.c
>> index f09ea77dd6a8..abd32ed8ec9b 100644
>> --- a/drivers/net/arcnet/com20020.c
>> +++ b/drivers/net/arcnet/com20020.c
>> @@ -102,6 +102,10 @@ int com20020_check(struct net_device *dev)
>>   	lp->setup = lp->clockm ? 0 : (lp->clockp << 1);
>>   	lp->setup2 = (lp->clockm << 4) | 8;
>>   
>> +	// If clock is major of 40Mhz, SLOWARB bit must be set
> 
> /* C89 style comments please :) */
> 

Done

> 
> Hope this helps,
> Tobin.
>