linux-kernel - Re: [PATCH 7/7] staging: ks7010: Move from bool to int in structs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180508113431.GA12019@kroah.com>
Date:   Tue, 8 May 2018 13:34:31 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/7] staging: ks7010: Move from bool to int in structs

On Sun, May 06, 2018 at 03:03:04PM -0700, Nathan Chancellor wrote:
> Fixes checkpatch.pl warnings.
> 
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> ---
>  drivers/staging/ks7010/ks_hostif.c   | 4 ++--
>  drivers/staging/ks7010/ks_wlan.h     | 4 ++--
>  drivers/staging/ks7010/ks_wlan_net.c | 8 ++++----
>  3 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> index 628171091786..43090922daff 100644
> --- a/drivers/staging/ks7010/ks_hostif.c
> +++ b/drivers/staging/ks7010/ks_hostif.c
> @@ -475,7 +475,7 @@ void hostif_mib_get_confirm(struct ks_wlan_private *priv)
>  	case DOT11_MAC_ADDRESS:
>  		hostif_sme_enqueue(priv, SME_GET_MAC_ADDRESS);
>  		ether_addr_copy(priv->eth_addr, priv->rxp);
> -		priv->mac_address_valid = true;
> +		priv->mac_address_valid = 1;

Wait, why?  This should be bool, not an int.  Why would checkpatch say
this is incorrect?

confused,

greg k-h