[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMz4kuLp=9Ae1UEE8LqoxBQneQ-x9T__WQ-zmtFf3n1AUUkUHw@mail.gmail.com>
Date: Tue, 8 May 2018 09:50:57 +0800
From: Baolin Wang <baolin.wang@...aro.org>
To: Rob Herring <robh@...nel.org>
Cc: jacek.anaszewski@...il.com, Pavel Machek <pavel@....cz>,
Mark Rutland <mark.rutland@....com>,
xiaotong.lu@...eadtrum.com, Mark Brown <broonie@...nel.org>,
linux-leds@...r.kernel.org, DTML <devicetree@...r.kernel.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: leds: Add SC27xx breathing light
controller documentation
Hi Rob,
On 8 May 2018 at 05:10, Rob Herring <robh@...nel.org> wrote:
> On Fri, May 04, 2018 at 06:08:35PM +0800, Baolin Wang wrote:
>> This patch adds the binding documentation for Spreadtrum SC27xx series
>> breathing light controller, which supports 3 outputs: red LED, green
>> LED and blue LED.
>>
>> Signed-off-by: Baolin Wang <baolin.wang@...aro.org>
>> ---
>> .../devicetree/bindings/leds/leds-sc27xx-bltc.txt | 39 ++++++++++++++++++++
>> 1 file changed, 39 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/leds/leds-sc27xx-bltc.txt
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-sc27xx-bltc.txt b/Documentation/devicetree/bindings/leds/leds-sc27xx-bltc.txt
>> new file mode 100644
>> index 0000000..d4e267d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/leds/leds-sc27xx-bltc.txt
>> @@ -0,0 +1,39 @@
>> +LEDs connected to Spreadtrum SC27XX PMIC breathing light controller
>> +
>> +The SC27xx breathing light controller supports to 3 outputs:
>> +red LED, green LED and blue LED. Each LED can work at normal
>> +PWM mode or breath light mode.
>> +
>> +Required properties:
>> +- compatible: should be "sprd,sc27xx-bltc".
>
> Don't use wildcards in compatible strings.
Will change to one explicit Soc name. Thanks.
--
Baolin.wang
Best Regards
Powered by blists - more mailing lists