[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20180508145948.9492-4-mpe@ellerman.id.au>
Date: Wed, 9 May 2018 00:59:43 +1000
From: Michael Ellerman <mpe@...erman.id.au>
To: linuxram@...ibm.com
Cc: mingo@...hat.com, linuxppc-dev@...abs.org, linux-mm@...ck.org,
x86@...nel.org, linux-kernel@...r.kernel.org, dave.hansen@...el.com
Subject: [PATCH 3/8] mm/pkeys: Remove include of asm/mmu_context.h from pkeys.h
While trying to unify the pkey handling in show_smap() between x86 and
powerpc we stumbled across various build failures due to the order of
includes between the two arches.
Part of the problem is that linux/pkeys.h includes asm/mmu_context.h,
and the relationship between asm/mmu_context.h and asm/pkeys.h is not
consistent between the two arches.
It would be cleaner if linux/pkeys.h only included asm/pkeys.h,
creating a single integration point for the arch pkey definitions.
So this patch removes the include of asm/mmu_context.h from
linux/pkeys.h.
We can't prove that this is safe in the general case, but it passes
all the build tests I've thrown at it. Also asm/mmu_context.h is
included widely while linux/pkeys.h is not, so most likely any code
that is including linux/pkeys.h is already getting asm/mmu_context.h
from elsewhere.
Signed-off-by: Michael Ellerman <mpe@...erman.id.au>
---
include/linux/pkeys.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/pkeys.h b/include/linux/pkeys.h
index 0794ca78c379..ed06e1a67bfa 100644
--- a/include/linux/pkeys.h
+++ b/include/linux/pkeys.h
@@ -3,7 +3,6 @@
#define _LINUX_PKEYS_H
#include <linux/mm_types.h>
-#include <asm/mmu_context.h>
#ifdef CONFIG_ARCH_HAS_PKEYS
#include <asm/pkeys.h>
--
2.14.1
Powered by blists - more mailing lists