linux-kernel - Re: [PATCH 2/2] tools/testing/selftests/x86: fix error: conflicting types for 'pkey_get|pkey

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <125eb810-1d48-394d-9665-40da64326fbb@intel.com>
Date:   Tue, 8 May 2018 09:30:04 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     Li Zhijian <lizhijian@...fujitsu.com>, shuah@...nel.org,
        linux-kselftest@...r.kernel.org
Cc:     mingo@...nel.org, tglx@...utronix.de, gregkh@...uxfoundation.org,
        pombredanne@...b.com, ebiederm@...ssion.com, luto@...nel.org,
        linux-kernel@...r.kernel.org, philip.li@...el.com,
        leist.fnst@...fujitsu.com, zhijianx.li@...el.com
Subject: Re: [PATCH 2/2] tools/testing/selftests/x86: fix error: conflicting
 types for 'pkey_get|pkey_set'

On 05/08/2018 02:14 AM, Li Zhijian wrote:
> -u32 pkey_get(int pkey, unsigned long flags)
> +u32 _pkey_get(int pkey, unsigned long flags)
>  {
>  	u32 mask = (PKEY_DISABLE_ACCESS|PKEY_DISABLE_WRITE);
>  	u32 pkru = __rdpkru();
> @@ -422,7 +426,7 @@ u32 pkey_get(int pkey, unsigned long flags)
>  	return masked_pkru;
>  }

I'm not a huge fan of random underscores for undocumented reasons.  But,
oh well.

Acked-by: Dave Hansen <dave.hansen@...el.com>