linux-kernel - Re: [PATCH 2/2] tools/testing/selftests/x86: fix error: conflicting types for 'pkey_get|pkey

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e80c9430-eaed-6a46-bde2-141b2e4266d2@kernel.org>
Date:   Tue, 8 May 2018 11:36:17 -0600
From:   Shuah Khan <shuah@...nel.org>
To:     Dave Hansen <dave.hansen@...el.com>,
        Li Zhijian <lizhijian@...fujitsu.com>,
        linux-kselftest@...r.kernel.org
Cc:     mingo@...nel.org, tglx@...utronix.de, gregkh@...uxfoundation.org,
        pombredanne@...b.com, ebiederm@...ssion.com, luto@...nel.org,
        linux-kernel@...r.kernel.org, philip.li@...el.com,
        leist.fnst@...fujitsu.com, zhijianx.li@...el.com,
        Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH 2/2] tools/testing/selftests/x86: fix error: conflicting
 types for 'pkey_get|pkey_set'

On 05/08/2018 10:30 AM, Dave Hansen wrote:
> On 05/08/2018 02:14 AM, Li Zhijian wrote:
>> -u32 pkey_get(int pkey, unsigned long flags)
>> +u32 _pkey_get(int pkey, unsigned long flags)
>>  {
>>  	u32 mask = (PKEY_DISABLE_ACCESS|PKEY_DISABLE_WRITE);
>>  	u32 pkru = __rdpkru();
>> @@ -422,7 +426,7 @@ u32 pkey_get(int pkey, unsigned long flags)
>>  	return masked_pkru;
>>  }
> 
> I'm not a huge fan of random underscores for undocumented reasons.  But,
> oh well.
> 
> Acked-by: Dave Hansen <dave.hansen@...el.com>
> 

Thanks. Queuing this up for 4.17-rc5

-- Shuah